This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Add support for Small/Notable Passive mods on all Time-Lost Jewels #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peechey
force-pushed
the
feature/process-time-lost-jewels-like-ATD
branch
from
4857637 to
da3e0a0
Compare
LocalIdentity
approved these changes
Jan 18, 2025
LocalIdentity
merged commit 69defed
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
|
I believe this has a bug where the modifiers are always applied to small nodes, even the ones that are meant to apply to notables only.
|
Contributor
Author
|
@dklymenk you are correct, I'm working on that right now, thanks for catching it though |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
Description of the problem being solved:
Open up the logic for Against the Darkness to apply to all Time-Lost jewels. Small and Notable Passive Skill mods that also grant stats should work for all these jewels given we parse the stat it's trying to add. Because of the way I grab the mod, there will be red-text mods on the jewel that actually parse and have the blue text when added to the passives. Little bonus treat.
Update: move weaponSet logic after time-lost logic to make sure only active nodes with jewel stats are calculated
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
after from issue:
